Fix blocky text on splash screen when using non-integer scale factor
ClosedPublic

Authored by ngraham on Jul 25 2018, 4:24 AM.

Details

Summary

The Qt bug that makes Text.NativeRendering look terrible with non-integer scale factors (https://bugreports.qt.io/browse/QTBUG-67007) is still a problem, so we need to apply the same workaround here that we previously applied to all the PlasmaComponents.

Test Plan

No visual change at 1x scale. Looks much better at 1.5x scale.

1.5x scale, before:

1.5x scale, after:

Diff Detail

Repository
R120 Plasma Workspace
Branch
fix-blocky-splash-screen-text (branched from Plasma/5.12)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1172
Build 1185: arc lint + arc unit
ngraham created this revision.Jul 25 2018, 4:24 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 25 2018, 4:24 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Jul 25 2018, 4:24 AM
ngraham edited the test plan for this revision. (Show Details)Jul 25 2018, 4:25 AM
broulik added inline comments.
lookandfeel/contents/splash/Splash.qml
92

You need to import QtQuick.Window 2.2 for that to work

ngraham updated this revision to Diff 38419.EditedJul 25 2018, 1:04 PM

Add the right import (this somehow works without it, so there must be an implicit import somewhere...)

ngraham marked an inline comment as done.Jul 25 2018, 1:04 PM
broulik accepted this revision.Jul 26 2018, 1:05 PM

Add the right import (this somehow works without it, so there must be an implicit import somewhere...)

More like it fails to assign [undefined] to int and then it never changes the default from QtRendering :)

This revision is now accepted and ready to land.Jul 26 2018, 1:05 PM
davidedmundson accepted this revision.Jul 26 2018, 1:09 PM

Anyway, ship it

Add the right import (this somehow works without it, so there must be an implicit import somewhere...)

More like it fails to assign [undefined] to int and then it never changes the default from QtRendering :)

...Which has no problems with fractional scale factors, yeah. So I didn't notice the difference.

Anyway thanks guys!

This revision was automatically updated to reflect the committed changes.