Search: Simplify result tab layout in search dialog
ClosedPublic

Authored by abika on Jul 21 2018, 4:27 PM.

Details

Reviewers
asensi
yurchor
Group Reviewers
Krusader
Summary

Code cleaning related to search

Some changes I did a while ago but did not push yet.
First commit changes the layout of the result tab in the search dialog a
bit. E.g. the "Search text:" field is only shown the user specified text to
search for.

The second commit is only code cleaning and should not change any
functionality.

Test Plan

Tested search function.

Diff Detail

Repository
R167 Krusader
Branch
my-search-improvements-arc
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1053
Build 1066: arc lint + arc unit
abika requested review of this revision.Jul 21 2018, 4:27 PM
abika created this revision.
abika added a subscriber: Krusader.
asensi added a subscriber: asensi.EditedJul 22 2018, 5:34 PM

First commit changes the layout of the result tab in the search dialog a
bit. E.g. the "Search text:" field is only shown the user specified text to
search for.

If it may help anyone:

Before applying the changes: the «General» tab:

Before applying the changes: having searched files (but without using the "containing text" option):

Before applying the changes: having searched files containing text:

After applying the changes: the «General» tab:

After applying the changes: having searched files (but without using the "containing text" option):

After applying the changes: having searched files containing text:

The second commit is only code cleaning and should not change any
functionality.

That code cleaning is visible (and very welcome :-)

asensi accepted this revision as: asensi.Jul 22 2018, 5:44 PM

Thank you, Alex! For my part, using Kubuntu 18.04: my performed tests went alright, and the source code looks better :-) . Other people can do their checks.

This revision is now accepted and ready to land.Jul 22 2018, 5:44 PM
yurchor accepted this revision as: yurchor.Jul 22 2018, 5:48 PM
abika closed this revision.Aug 12 2018, 3:59 PM

pushed. Forgot to include the link to this Diff in the commit message:/

Thanks for testing and the screenshots!