Differential D14256

Fix sidebar search field with fractional scale factors
ClosedPublic
Actions

Authored by ngraham on Jul 20 2018, 11:16 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R124:1cb8b2af21df: Fix sidebar search field with fractional scale factors
Summary

By using a QQC2 TextField, we improve the appearance when using a fractional scale factor without regressing anything for integer scale factors and no scale factor.

Test Plan

Search still works, clear button still works, appearance is improved with a fractional scale factor. No change with an integer scale factor or no scale factor.

1.3x scale, before:

1.3x scale, after:

Diff Detail

Repository
R124 System Settings
Branch
sidebar-textfield (branched from Plasma/5.12)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1043
Build 1056: arc lint + arc unit
ngraham created this revision.Jul 20 2018, 11:16 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 20 2018, 11:16 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Jul 20 2018, 11:16 PM
ngraham edited the summary of this revision. (Show Details)Jul 20 2018, 11:18 PM
ngraham edited the test plan for this revision. (Show Details)
davidedmundson accepted this revision.Jul 20 2018, 11:52 PM
This revision is now accepted and ready to land.Jul 20 2018, 11:52 PM
Closed by commit R124:1cb8b2af21df: Fix sidebar search field with fractional scale factors (authored by ngraham). · Explain WhyJul 22 2018, 2:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 38151

View Options

sidebar/package/contents/ui/CategoriesPage.qml

Loading...