@graesslin Thanks for review, but David wanted me to use a cached variable in KWayland. That's why I had to rework the KWin implementation as well. Sorry. Would appreciate another review for this revision.

graesslin added inline comments.Jul 17 2018, 7:55 PM

pointer_input.cpp
698	const auto
713	I have problems following what's going on here. Maybe add some comments?

Add comments, constify

Harbormaster completed remote builds in B964: Diff 37988.Jul 18 2018, 7:08 AM

romangg marked 2 inline comments as done.Jul 18 2018, 7:08 AM

Closed by commit R108:054ccc389899: Use locked cursor position hint (authored by romangg). · Explain WhyJul 27 2018, 3:20 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			pointer_input.h (2 lines)
M			pointer_input.cpp (30 lines)
M			tests/pointerconstraintstest.h (9 lines)
M			tests/pointerconstraintstest.cpp (6 lines)
M			tests/pointerconstraintstest.qml (29 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	37918	f0ba436		Jul 17 2018, 12:51 AM	★	★
Diff 2	37972	f0ba436	- Use hint getter	Jul 17 2018, 4:27 PM	★	★
Diff 3	37988	653e98d	- Add comments, constify	Jul 18 2018, 7:07 AM	★	★
Diff 4	38613	d723ce2	R108:054ccc389899acf1f15001105e8b03a4ffb203d0	Jul 27 2018, 3:19 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
ae14ab73cafd	8ad154f7e4e7	cd71326fdcae	Roman Gilg	Add comments, constify	Jul 18 2018, 7:06 AM
cd71326fdcae	9ca9971f9aa5	45eaba40e5ab	Roman Gilg	Use hint getter	Jul 17 2018, 4:21 PM
45eaba40e5ab	b65647c10cf8	653e98d5ac0a	Roman Gilg	Use locked cursor position hint (Show More…)	Jul 17 2018, 12:08 AM