Extracted kis_filter category KoIDs to separate file
ClosedPublic

Authored by victorw on Jul 16 2018, 5:15 PM.

Details

Reviewers
rempt
Group Reviewers
Krita
Summary

Small change as a step towards T6560.

Please note any concerns you may have with this as it may serve as a base for how other KoIDs should be extracted. The plan is to make it easier to locate, use, and reason about existing KoIDs.

Diff Detail

Repository
R37 Krita
Lint
Lint Skipped
Unit
Unit Tests Skipped
victorw created this revision.Jul 16 2018, 5:15 PM
Restricted Application added a reviewer: Krita. ยท View Herald TranscriptJul 16 2018, 5:15 PM
victorw requested review of this revision.Jul 16 2018, 5:15 PM
victorw added inline comments.Jul 16 2018, 5:21 PM
libs/image/filter/kis_filter.h
42

I don't have to remove these, but if you want to add or remove a category it's one more step you have to do.

libs/image/filter/kis_filter_category_ids.h
27

This and the corresponding cpp file is the real change.

victorw added inline comments.Jul 16 2018, 5:31 PM
libs/image/filter/kis_filter_category_ids.h
35

Apparently we don't have any filters in this category?

woltherav added inline comments.
libs/image/filter/kis_filter_category_ids.h
35

Nope. There may have been in the past, I guess?

rempt accepted this revision.Jul 17 2018, 6:26 AM

I guess we might just as well remove the categories that aren't used.

This revision is now accepted and ready to land.Jul 17 2018, 6:26 AM