[effects/slide] Add "Slide desktop background" option
ClosedPublic

Authored by zzag on Jun 14 2018, 4:27 PM.

Details

Summary

Some people may not like the sliding of desktop background. Add
corresponding option to disable the sliding of desktop background.

By disabling the sliding of desktop background and docks, one can
get old slide effect.

Test Plan
  • Unchecked "Slide desktop background" checkbox, switched desktop;
  • Checked "Slide desktop background" checkbox, switched desktop.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Jun 14 2018, 4:27 PM
Restricted Application added a project: KWin. · View Herald TranscriptJun 14 2018, 4:27 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Jun 14 2018, 4:27 PM
zzag edited the summary of this revision. (Show Details)Jun 14 2018, 4:27 PM
romangg added inline comments.
effects/slide/slide.cpp
251

return m_slideBackground || m_paintCtx.fristPass;

The comment above it can be understood in two different ways. Maybe make it more precise.

zzag updated this revision to Diff 36171.Jun 14 2018, 5:47 PM

Use logical or instead of a ternary operator

zzag updated this revision to Diff 36173.Jun 14 2018, 5:53 PM

More precise comments

zzag marked an inline comment as done.Jun 14 2018, 5:59 PM
ngraham added inline comments.Jun 14 2018, 8:51 PM
effects/slide/slide_config.ui
105

While we're touching this, is "Slide docks" really the right string? We have Panels, not Docks, right?

zzag added inline comments.Jun 14 2018, 9:03 PM
effects/slide/slide_config.ui
105

Well, from libkwineffects POV, yes. From users POV, maybe. (I added that checkbox in the first place because of latte dock. It honors full screen windows so that's okay to not slide it)

If you insist on changing "Slide docks" to "Slide panels", I'll change it, but not in this diff.

ngraham added inline comments.Jun 14 2018, 9:07 PM
effects/slide/slide_config.ui
105

No, I don't insist, it was just a thought. Maybe "docks and panels?" Because not everyone uses Latte Dock.

Fine for another patch.

zzag added inline comments.Jun 14 2018, 9:08 PM
effects/slide/slide_config.ui
105

Maybe "docks and panels?"

Yes, it's even better!

ngraham accepted this revision as: VDG.Jun 15 2018, 9:44 PM

VDG-wise, this is good.

mart accepted this revision.Jun 19 2018, 8:52 AM
This revision is now accepted and ready to land.Jun 19 2018, 8:52 AM
This revision was automatically updated to reflect the committed changes.