piano_composition, add a dialog to show warning before deleting all notes and other features
ClosedPublic

Authored by amankumargupta on Jun 13 2018, 1:30 PM.

Details

Summary

This task covers the following features and improvements:

  1. Add a dialog to show warning before deleting all notes.
  2. When clicking on an option button we should display a temporary message telling what it is.
  3. Visually indicate that the rest option and add button are the parts of a common feature.
  4. Replace tick button with + button.

Diff Detail

Repository
R2 GCompris
Lint
Lint Skipped
Unit
Unit Tests Skipped
amankumargupta created this revision.Jun 13 2018, 1:30 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptJun 13 2018, 1:30 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
amankumargupta requested review of this revision.Jun 13 2018, 1:30 PM
jjazeix added inline comments.
src/activities/piano_composition/OptionsRow.qml
66

need a translator comment to understand what is %1.
I think it may be better to have "Whole note", "Half note" directly above instead of having "%1 note" here for translation purposes.

95

same as above, better have "Treble clef", "Bass clef"

amankumargupta marked 2 inline comments as done.
jjazeix accepted this revision.Jun 14 2018, 7:08 PM
jjazeix added inline comments.
src/activities/piano_composition/OptionsRow.qml
137

translators do not know about the translatedRestNames variable.
It may be complicated for translators to have one translation inside another one, if you can keep one text with the whole context, it is easier

This revision is now accepted and ready to land.Jun 14 2018, 7:08 PM