Differential D13350

[FreeSpaceNotifier] Use KIO FileSystemFreeSpaceJob
ClosedPublic
Actions

Authored by broulik on Jun 5 2018, 8:45 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R120:fb96a53daaaa: [FreeSpaceNotifier] Use KIO FileSystemFreeSpaceJob
Summary

Which delegates the task of doing it to a out of process IO slave and makes it asynchronous.
KDiskFreeSpaceInfo blocks querying mount points and might freeze for a while with NFS stuff.

Test Plan

Shouldn't be too bad as it's KDED and only done every minute but still

  • Fiddled with the limit, SNI showed up after a while
  • Deleted a large file, SNI disappeared after a while

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jun 5 2018, 8:45 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 5 2018, 8:45 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jun 5 2018, 8:45 AM
This revision is now accepted and ready to land.Jun 5 2018, 9:19 AM
Closed by commit R120:fb96a53daaaa: [FreeSpaceNotifier] Use KIO FileSystemFreeSpaceJob (authored by broulik). · Explain WhyJun 5 2018, 10:08 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 35601

View Options

freespacenotifier/freespacenotifier.cpp

Loading...