This patch adds the single/double click option to
the Workspace KCM.
BUG: 393547
BUG: 377310
romangg | |
ngraham | |
mart |
Plasma |
This patch adds the single/double click option to
the Workspace KCM.
BUG: 393547
BUG: 377310
No Linters Available |
No Unit Test Coverage |
kcms/workspaceoptions/package/contents/ui/main.qml | ||
---|---|---|
84 | I don't want to bike shed on this given the timing, but it is not just about files and folders. The old wording was "select and activate icons". |
kcms/workspaceoptions/package/contents/ui/main.qml | ||
---|---|---|
90 | This is not okay. If singleclick is not set initially, doubleclick radio button should be enabled. This code doesn't to that. |
kcms/workspaceoptions/package/contents/ui/main.qml | ||
---|---|---|
82 | Add: checked: !kcm.singleClick | |
90 | singleClick will be set initially through https://phabricator.kde.org/D12946#inline-66775 But you are right, it also needs checked: !kcm.singleClick for doubleClick to work. |
kcms/workspaceoptions/package/contents/ui/main.qml | ||
---|---|---|
84 | yes, text should still be double click to activate icons |
kcms/workspaceoptions/package/contents/ui/main.qml | ||
---|---|---|
84 | It's already changed, right? |
kcms/workspaceoptions/package/contents/ui/main.qml | ||
---|---|---|
84 | i still see text: i18n("Single-click to open files and folders") |
kcms/workspaceoptions/package/contents/ui/main.qml | ||
---|---|---|
84 | It was added to the double click setting below (such that the text reads now exactly like it was in the Mouse KCM). |
kcms/workspaceoptions/package/contents/ui/main.qml | ||
---|---|---|
84 | ok |
hey guys, resident grammar nazi reporting :D
it says Click Behaviour (british spelling), and the rest of the module uses Behavior (american spelling)
a great idea otherwise
sorry :D