Unselect all items when calculating occupied space on ".."
ClosedPublic

Authored by gengisdave on May 15 2018, 8:05 PM.

Details

Reviewers
martinkostolny
nmel
asensi
Group Reviewers
Krusader
Summary

When using Space on ".." or Calculate Occupied Space, Krusader selects all items to populate the calculation list.

After the list is created, the elements can be unselected.

FIXED: [ 150247 ] When calculating occupied space of ".." , krusader selects all directories
BUG: 150247

Test Plan

No elements should be remain selected when calculating occupied space

Diff Detail

Repository
R167 Krusader
Lint
Lint Skipped
Unit
Unit Tests Skipped
gengisdave requested review of this revision.May 15 2018, 8:05 PM
gengisdave created this revision.
martinkostolny added a subscriber: martinkostolny.

Works as expected. Thanks! :)

This revision is now accepted and ready to land.May 16 2018, 7:33 PM
nmel accepted this revision.May 17 2018, 5:25 AM
nmel added a subscriber: nmel.

Great, it works as expected. Thanks Davide!
BTW, I didn't know about this nice little feature. It is convenient.

Just a minor suggestion: please be a little more specific in the commit header, like Unselect all items when calculating occupied space on '..' (since in a normal scenario you don't unselect items).

asensi accepted this revision.May 17 2018, 9:27 PM
asensi added a subscriber: asensi.

For my part, my performed tests went also OK!

[...] Unselect all items when calculating occupied space on '..' (since in a normal scenario you don't unselect items).

I think the same, too :-)

Thanks for this series of improvements, Davide!

gengisdave retitled this revision from Unselect all items when calculating occupied space to Unselect all items when calculating occupied space on "..".May 19 2018, 9:49 AM
nmel added a comment.May 20 2018, 3:45 AM

Thanks Davide and Toni.

Devs, don't forget to include a line Differential Revision: https://phabricator.kde.org/Dxxxxx into your commit message. This way commit becomes linked to the CR discussion (for example, observe the intergation here) and the revision is closed automatically by your commit. If you use arc, it's done automatically (commit message will need some cleanup though), however if you don't use the tool, please insert manually. Thanks!