Differential D12605

added 'add_to_places' action to file menu and as a shortcut
AbandonedPublic
Actions

Authored by ngraham on Apr 29 2018, 7:21 PM.

Details

Reviewers
rpetrov
Group Reviewers
Dolphin
Summary

Added an action to the "File" menu to add the currently opened folder to the "Places" pane.
Also added the shortcut "Ctrl + D" for this action.

BUG: 390757

Test Plan

I tested it with a single tab open, as well as with two, in both cases the currently active "window" is used get the current folder

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
rpetrov requested review of this revision.Apr 29 2018, 7:21 PM
rpetrov created this revision.
ngraham requested changes to this revision.May 9 2018, 1:23 PM
ngraham added a subscriber: ngraham.

Dunno how I missed this, sorry!

The keyboard shortcut works, but I can't actually see the new item in the file menu. Also, you need to bump the version on dolphinui.rc.

This revision now requires changes to proceed.May 9 2018, 1:23 PM
Restricted Application added a subscriber: kfm-devel. · View Herald TranscriptMay 9 2018, 1:23 PM
markg added a subscriber: markg.May 9 2018, 1:45 PM
markg added inline comments.
src/dolphinmainwindow.cpp
1243

Please do not use CTRL+D as key binding.
It already has a mix of things it does.

In Konsole: it closes the current tab
In Chrome: it adds the current page to your bookmarks

ngraham added inline comments.May 9 2018, 1:47 PM
src/dolphinmainwindow.cpp
1243

I think the idea was to piggyback on the "bookmarks" idea, since places are basically bookmarks in Dolphin. I think it's okay.

rpetrov updated this revision to Diff 34023.EditedMay 12 2018, 2:14 PM

bumped up version in dolphinui

I built and executed it in both the docker environment (plasma:dev-unstable) as well as kde-neon (git-unstable), in both cases the menu item was available. Any ideas as to why it might not show up on your machine @ngraham ?

rpetrov added inline comments.May 12 2018, 2:18 PM
src/dolphinmainwindow.cpp
1243

as @ngraham said, the idea was to use a common mnemonic for bookmarks, i could also change it to something else or alternatively don't set a default shortcut.

ngraham added a comment.May 14 2018, 2:24 PM

I see the menu item when I try a new user account, which points to an issue showing it for existing users who already have a config file. I thought that bumping the version on dolphinui.rc would fix that, but apparently it didn't...

meven added a subscriber: meven.Jan 13 2020, 7:58 AM

D26590 reminded me of this one.

src/dolphinmainwindow.cpp
1248

I don't think we need a shortcut for this, and this one in particular will be used by the duplicate feature D8208

ngraham added a comment.Jan 13 2020, 3:13 PM

The "Add to Places" action is in fact already in the menu, so I don't think this revision is needed anymore.

ngraham commandeered this revision.Jan 13 2020, 3:13 PM
ngraham abandoned this revision.
ngraham edited reviewers, added: rpetrov; removed: ngraham.

Revision Contents
Changeset List

PathPackages
Msrc/dolphinmainwindow.h (5 lines)
Msrc/dolphinmainwindow.cpp (22 lines)
Msrc/dolphinui.rc (4 lines)

Diff 34023

View Options

src/dolphinmainwindow.h

Loading...
View Options

src/dolphinmainwindow.cpp

Loading...
View Options

src/dolphinui.rc

Loading...