| romangg |
Done primarily for XWayland which for legacy reasons doesn't assume the
logical size of a display is pixelSize / outputScale. Meaning xwayland
windows that position themselves are wrong in a scaled environment.
It also allows the possibility for us to support fractional scaling
whilst keeping wl_output::scale as an integer.
The protocol is a bit odd as it operates via the FooManager + Foo
pattern rather than using globals like Output so I've wrapped it so it
behaves more like globals.
| No Linters Available |
| No Unit Test Coverage |
| src/client/registry.h | ||
|---|---|---|
| 624 | Function createXdgOutputUnstableV1 does not exist. Do you mean createXdgOutputManager? | |
Replace XDGOUTPUTVERSION with the next framework release version.
I will do that when merging as I don't know at time of review what version that is going to be.
| src/server/display.h | ||
|---|---|---|
| 263 | the XdgOutputManagerInterface | |
| src/server/xdgoutput_interface.cpp | ||
| 108 | You do not want to connect the destroyed signal of this (i.e. the one of the XdgOuputManagerInterface) here but the one of the new XdgOutputInterface, right? | |
| 132 | Comment: client is requesting XdgOutput for output, that doesn't exist | |
According to protocol the logical size and position events should only be send
(i) on creation of an xdg_output object and
(ii) when the size or position changed.
There is currently no check in the server interface, if the size and position really changed when the compositor tries to send the event. Looking at the KWin patch, this is currently done sometimes when there has been no change.
Maybe there should be a comparison of old and new value in KWayland to prohibit sending out events on unchanged values (this would mean saving the current values in XdgOutputV1Interface::Private).
| src/server/xdgoutput_interface.cpp | ||
|---|---|---|
| 84 | This variable is only relevant until the compositor has sent for the first time the done event via XdgOutputInterface::done(). Afterwards it is always true. Is it meant this way? If yes, could we use another name making this fact more explicit, like: doneOnce? On the other side what if a compositor never sends the done event via XdgOutputInterface::done() because the xdg output never changes its logical size or position after the compositor publishes the xdg output to clients and it expects clients to receive the current values on connecting to the resource? | |
| src/server/xdgoutput_interface.cpp | ||
|---|---|---|
| 84 | The inline comment is in the wrong line. It is referring to the done member variable. | |
| src/server/xdgoutput_interface.cpp | ||
|---|---|---|
| 84 |
It is. I can make that change
It should be set on creation. If it's not the compositor is doing things wrong. I can update the docs to make it clear | |