Don't try to filter null key combinations
ClosedPublic

Authored by apol on Apr 21 2018, 4:36 PM.

Details

Summary

When using composite key combinations, kwin would do random weird
actions when the first key was pressed (e.g. ` key). This makes sure we
are not trying to match.

BUG: 390110

Diff Detail

Repository
R108 KWin
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
apol created this revision.Apr 21 2018, 4:36 PM
Restricted Application added a project: KWin. · View Herald TranscriptApr 21 2018, 4:36 PM
Restricted Application added subscribers: KWin, kwin. · View Herald Transcript
apol requested review of this revision.Apr 21 2018, 4:36 PM
apol updated this revision to Diff 32726.

Don't try to filter null key combinations

When using composite key combinations, kwin would do random weird
actions when the first key was pressed (e.g. ` key). This makes sure we
are not trying to match.

apol retitled this revision from a to Don't try to filter null key combinations.Apr 21 2018, 4:37 PM
apol edited the summary of this revision. (Show Details)
apol added a reviewer: KWin.
graesslin requested changes to this revision.Apr 22 2018, 1:43 PM
graesslin added a subscriber: graesslin.

Ah you are my hero! I was not understanding this bug and failed to reproduce it. Could you please add a small test case for it? should be relative straight forward and we have quite a few tests for global shortcuts already. And please mark bug 390110 as fixed, which also means I want this in 5.12 :-)

This revision now requires changes to proceed.Apr 22 2018, 1:43 PM
apol edited the summary of this revision. (Show Details)Apr 22 2018, 5:36 PM
apol updated this revision to Diff 32886.Apr 23 2018, 2:08 PM
apol edited the summary of this revision. (Show Details)

Add test

graesslin accepted this revision.Apr 23 2018, 7:39 PM

Thanks for adding the test.

This revision is now accepted and ready to land.Apr 23 2018, 7:39 PM
This revision was automatically updated to reflect the committed changes.
fvogt added a subscriber: fvogt.Apr 24 2018, 2:30 PM

Plasma/5.12?