Remove duplicate overwrite confirmation dialog
ClosedPublic

Authored by muhlenpfordt on Apr 19 2018, 12:26 PM.

Details

Summary

When trying to overwrite a file using e.g. FileSave As
the confirmation dialog is duplicated.
This patch removes the additional Gwenview overwrite check since
QFileDialog shows its own dialog to confirm overwrite.

FIXED-IN: 18.04.1

Test Plan
  1. Start Gwenview in View or Browse Mode
  2. FileSave As or Ctrl++S
  3. Select an existing file as destination
  4. After confirmation no other dialog should ask again

Diff Detail

Repository
R260 Gwenview
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
muhlenpfordt requested review of this revision.Apr 19 2018, 12:26 PM
muhlenpfordt created this revision.

This bug was the reason for adding Gwenview's check: dc2188907b54.
KFileDialog did not support its own confirmation until v4.2: KFileDialog::setConfirmOverwrite(). After introduction it seems the default was disabled.
QFileDialog's confirmation dialog is default now: QFileDialog::Options.

ngraham accepted this revision.Apr 19 2018, 2:24 PM
ngraham added a subscriber: ngraham.

Works great! This was really annoying. Thanks for fixing it!

This revision is now accepted and ready to land.Apr 19 2018, 2:24 PM
huoni added a subscriber: huoni.Apr 20 2018, 6:25 AM

Also LGTM :)

rkflx accepted this revision.Apr 20 2018, 9:29 PM
rkflx added a subscriber: rkflx.

I have nothing to add to the other reviewer's judgements :)

Also checked with XDG_CURRENT_DESKTOP=gnome gwenview, which is just fine. (Let's not forget when testing that for file dialog operations sometimes we can end up in GTK, which might handle things differently.)

This bug was the reason for adding Gwenview's check: dc2188907b54.
KFileDialog did not support its own confirmation until v4.2: KFileDialog::setConfirmOverwrite(). After introduction it seems the default was disabled.
QFileDialog's confirmation dialog is default now: QFileDialog::Options.

Thanks for the analysis, saves time when reviewing!

This revision was automatically updated to reflect the committed changes.