For a consistent UX use the same component for config UI elements
showing a currently selected color and allowing to trigger a color picker to
select another color.
Details
Details
- Reviewers
davidedmundson - Group Reviewers
Plasma VDG - Commits
- R114:f3ad84f91946: Consistently use KQuickControls.ColorButton in the config UI
All buttons adapt to color changes as well as trigger the color dialog if
activated and take over any chosen color.
Diff Detail
Diff Detail
- Repository
- R114 Plasma Addons
- Branch
- useconsistentcolorbutton
- Lint
No Linters Available - Unit
No Unit Test Coverage
| applets/systemloadviewer/package/contents/ui/ColorPicker.qml | ||
|---|---|---|
| 2 | Open question to developers: That's where the code for both ColorButtons here is yet to be aligned. | |
Comment Actions
There's ColorButton (https://api.kde.org/frameworks/kdeclarative/html/classColorButton.html) inside kquickcontrols
Can't we use that?
| applets/systemloadviewer/package/contents/ui/ColorPicker.qml | ||
|---|---|---|
| 2 | It's open source, you can see what Qt Dialogs does internally. | |
Comment Actions
Ah, I had only grepped for ColorDialog and before also only seen that custom code in the image wallpaper config. From quick testing that one works as well, and is used in Fifteenpuzzle config UI.
Though not anywhere else. Leaves me slightly puzzled why nothing else has used it before and instead did own creations?
With KQuickControls.ColorButton:
Would do similar patches for image wallpaper & similar as well if this one is okayed.