We cannot rely on pkgconfig only so use more advanced search for libs
required by screencast portal
Details
Details
- Reviewers
krop - Group Reviewers
Plasma - Commits
- R838:0ff113d3dcbd: Search properly for pipewire and other libs
Diff Detail
Diff Detail
- Repository
- R838 Flatpak Support: KDE Portal for XDG Desktop
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
Findpipewire.cmake and Findspa.cmake are copies of Findgbm.cmake and just modified accordingly, Findglib.cmake is copied from webkit.
| CMakeLists.txt | ||
|---|---|---|
| 24 | GLib | |
| 30 | Spa (see below) | |
| 36 | PipeWire | |
| 42 | unrelated to this request but the file should be called FindGBM.cmake and the vars changed | |
| cmake/modules/Findglib.cmake | ||
| 1 | The file should be renamed FindGLib.cmake and the variables be changed | |
| 4–6 | GLib_FOUND, GLib_INCLUDE_DIRS, GLIB_LIBRARIES... | |
| 13–16 | GIO | |
| cmake/modules/Findpipewire.cmake | ||
| 2 | FindPipeWire and rename the file and variables | |
| 62–67 | Not needed, the file is not installed and the module already requires 2.8.12 | |
| 69 | Remove | |
| 78 | PipeWire_INCLUDE_DIRS | |
| 85 | PipeWire_LIBRARIES | |
| 114–117 | Remove, this is a new module, you don't need compat vars | |
| cmake/modules/Findspa.cmake | ||
| 2 | FindSPA (and rename the vars and the file) | |
| 9 | SPA_FOUND | |
| 13 | SPA_LIBRARIES (and same thing for the other vars) | |
| 62–67 | Not needed, the module already requires 2.8.12 and this file is not installed. | |
| 69 | Not needed. Remove this line (& the matching endif()) | |
| 114–117 | This module is new, you don't need compat variables. | |
| src/CMakeLists.txt | ||
| 6 | Not needed for gbm, SPA and PipeWire, you created targets | |
| 56 | PipeWire::PipeWire | |
| 57 | Spa::Spa | |
| 58 | GLIB_LIBRARIES was fine (well, GLib_LIBRARIES once the file is fixed) | |
| 60 | why ? | |