Clean up home buttons
ClosedPublic

Authored by rizzitello on Apr 7 2018, 3:52 AM.

Details

Summary

Move home actions to a new home button (QAction) on click it will send home all when its menu is exposed the user can select the axis individually. This places the most common action in the toolbar and the less common action in the menu.

Before:

After:

Test Plan

Get input from VDG on the change.

Diff Detail

Repository
R231 Atelier
Branch
homeToolButton
Lint
No Linters Available
Unit
No Unit Test Coverage
rizzitello requested review of this revision.Apr 7 2018, 3:52 AM
rizzitello created this revision.
rizzitello edited the summary of this revision. (Show Details)Apr 7 2018, 3:59 AM
rizzitello updated this revision to Diff 31555.Apr 7 2018, 4:02 AM
  • Icons on the menu
rizzitello updated this revision to Diff 31556.Apr 7 2018, 4:03 AM
  • Remove toolbar text flag

For some odd reason the menu isnt appearing for me. Will try to discover why.

rizzitello updated this revision to Diff 31642.Apr 8 2018, 1:27 AM
  • Rebase
  • Use Pushbutton
rizzitello updated this revision to Diff 31643.Apr 8 2018, 1:51 AM
  • Use Action with Menu
rizzitello updated this revision to Diff 31644.Apr 8 2018, 1:57 AM
  • Remove unused include
rizzitello edited the summary of this revision. (Show Details)Apr 8 2018, 12:39 PM
rizzitello edited the summary of this revision. (Show Details)Apr 8 2018, 1:21 PM
rizzitello edited the test plan for this revision. (Show Details)
rizzitello added a reviewer: VDG.
rizzitello added a subscriber: VDG.
ngraham added a subscriber: ngraham.Apr 8 2018, 2:19 PM

Taking off my VDG hat and putting on my 3D printer operator hat...

-1, sorry. Homing all axes is not necessarily the most common operation. I often home just the X or Y axis on my machine, and this would make that a bit harder. What might be nicer than the status quo without going this far is just improving the labeling:

🏠 Home axes: All X Y Z

ngraham removed a subscriber: ngraham.Apr 8 2018, 2:20 PM
ngraham added a subscriber: ngraham.Apr 8 2018, 2:26 PM
abetts added a subscriber: abetts.Apr 8 2018, 2:27 PM

Just to understand. Where does this need come from?

Just to understand. Where does this need come from?

Trying to tidy up the bar and ultimately combine two toolbars into one..
D12008
D12009
D12046

rizzitello updated this revision to Diff 31674.Apr 8 2018, 3:04 PM
rizzitello edited the test plan for this revision. (Show Details)
  • nate's grouping suggestion
ngraham accepted this revision.Apr 8 2018, 3:05 PM

That looks good to me!

This revision is now accepted and ready to land.Apr 8 2018, 3:05 PM
rizzitello edited the summary of this revision. (Show Details)Apr 8 2018, 3:07 PM
rizzitello updated this revision to Diff 31676.Apr 8 2018, 3:11 PM
  • Remove space after "Home:"
rizzitello closed this revision.Apr 9 2018, 8:25 PM