Implemented bookmark quick search
ClosedPublic
Actions

Authored by nmel on Apr 3 2018, 6:10 AM.

Details

Reviewers

martinkostolny
rade
asensi
gengisdave
abika

Group Reviewers

Krusader

Commits

R167:a7f169df15d8: Implemented bookmark quick search

Summary

Merge branch 'bookmark-quicksearch' into master

ADDED: bookmark quick search (type symbols in bookmark menu to activate)

This is the final code review for the bookmark quick search feature that
Rade, Martin and myself have been working on recently.

Test Plan

You can find discussions in the intermediate CRs:
D10954
D11224
D11383
D11523
D11538
D11444
D11525
D11623
D11624
D11706
D11731
D11829

Apply the patch to the master branch.
Please test various aspects of the bookmark search for this merge.

Diff Detail

Repository

R167 Krusader

Branch

bookmark-search-merge_arc

Lint

No Linters Available

Unit

No Unit Test Coverage

nmel created this revision.Apr 3 2018, 6:10 AM

Restricted Application added a subscriber: kde-doc-english. · View Herald TranscriptApr 3 2018, 6:10 AM

nmel requested review of this revision.Apr 3 2018, 6:10 AM

+ more devs for visibility. Please test if you have time.

Thank you all!

Please test various aspects of the bookmark search for this merge.

One thing I have noticed, at least using Kubuntu 17.10:
If a user has opened his bookmark menu, he has a bookmark named "Documents"
and he presses Shift+D... nothing happens.

The expected results would be that pressing Shift+D would carry the user to the
"Documents" place, like pressing Shift+D does when browsing files normally.

In D11898#239150, @asensi wrote:

If a user has opened his bookmark menu, he has a bookmark named "Documents"
and he presses Shift+D... nothing happens.

Good catch! I have created a fix for that here D11906

Updated the merge.

asensi accepted this revision as: asensi.Apr 5 2018, 10:19 PM

This revision is now accepted and ready to land.Apr 5 2018, 10:19 PM

Toni, thanks for the review and testing!

I'll wait for others till the EOW. If no complains, I'm going to push it on Monday.

I assume Martin and Rade are also fine with merging this branch. We tested it a lot during the development stage.

In D11898#242741, @nmel wrote:

I assume Martin and Rade are also fine with merging this branch. We tested it a lot during the development stage.

My bad, I assumed that was a given so I didn't bother replying. I am definitely all in favour of merging this.

rade accepted this revision.Apr 8 2018, 8:31 PM

Same goes for me, sorry for not replying. The patch works as expected :).

Closed by commit R167:a7f169df15d8: Implemented bookmark quick search (authored by nmel). · Explain WhyApr 10 2018, 4:14 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			doc/bookmarks.docbook (31 lines)
M			doc/konfigurator.docbook (15 lines)
M			krusader/BookMan/krbookmark.h (15 lines)
M			krusader/BookMan/krbookmark.cpp (36 lines)
M			krusader/BookMan/krbookmarkbutton.cpp (4 lines)
M			krusader/BookMan/krbookmarkhandler.h (15 lines)
M			krusader/BookMan/krbookmarkhandler.cpp (270 lines)
M			krusader/Konfigurator/kgpanel.cpp (16 lines)
M			krusader/krusader.cpp (5 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	31192	1d30065		Apr 3 2018, 6:10 AM	★	★
Diff 2	31350	706b9f7	Updated the merge.	Apr 5 2018, 4:54 AM	★	★
Diff 3	31785	2fbd49f	R167:a7f169df15d84a083a10b35864bc59cce03a44db	Apr 10 2018, 4:08 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
330bb66c4276	4510b12e29fe	706b9f78fe85 296b099f6b39	Nikita Melnichenko	Implemented bookmark quick search (Show More…)	Apr 5 2018, 4:50 AM
296b099f6b39	7d6c2d128d05	89ee1833bedf	Rade Deguerre	Added support for capitalization when searching bookmarks (Show More…)	Apr 4 2018, 9:25 AM
89ee1833bedf	05e57c36f2d7	c118ca1eb5fd 76ff72a8885b	Nikita Melnichenko	Fixed bugs in bookmark search that appear after exiting from submenu (Show More…)	Apr 3 2018, 4:26 AM
76ff72a8885b	05e57c36f2d7	e3c26269ddc3	Nikita Melnichenko	Improved return value for Show, Close events in KrBookmarkHandler::eventFilter	Apr 3 2018, 3:19 AM
e3c26269ddc3	0fcee4bab855	4a805ddf836e	Nikita Melnichenko	Simplified if statements in KrBookmarkHandler::eventFilter	Apr 2 2018, 12:06 AM
4a805ddf836e	e875d446f8c2	84888d3bff98	Nikita Melnichenko	Fixed active item deselection when starting search after exiting from submenu (Show More…)	Mar 31 2018, 6:48 AM
84888d3bff98	245102af32d4	c118ca1eb5fd	Nikita Melnichenko	Fixed bookmark search key swallowing after exiting from submenu (Show More…)	Mar 31 2018, 6:37 AM
c118ca1eb5fd	3ca049c76c3a	43db17a602dc	Martin Kostolný	Comment added to explain a removal of _quickSearchAction before every menu… (Show More…)	Mar 29 2018, 9:27 PM
43db17a602dc	8418352b623a	7e57c7204fd3	Yuri Chornoivan	Add docs for the new Konfigurator option 'Search in special items'	Mar 29 2018, 1:33 PM
7e57c7204fd3	af5547fd0e2e	61a46a181598 c4f8a3b937c2	Martin Kostolný	Merge branch 'bookmark-quicksearch-disappearing-searchbar' into bookmark… (Show More…)	Mar 27 2018, 9:48 PM
c4f8a3b937c2	af5547fd0e2e	61a46a181598	Martin Kostolný	Fix disappearing searchbar when bookmark menu is opened for another tab. (Show More…)	Mar 26 2018, 10:23 PM
61a46a181598	4fa9a3eac900	2bbaedfebaf7	Nikita Melnichenko	Fixed the issue with jump back actions not closing bookmark menu when triggered (Show More…)	Mar 26 2018, 6:52 AM
2bbaedfebaf7	1e2da846911e	d17d5fb4ddf1	Nikita Melnichenko	Added a setting for bookmark search: Search in special items (Show More…)	Mar 26 2018, 5:37 AM
d17d5fb4ddf1	d91dabf59dcf	0697fa50911d	Nikita Melnichenko	Add back Jump Back actions to special bookmarks (Show More…)	Mar 25 2018, 3:43 AM
0697fa50911d	a71d5ff63348	2841d0f45dc6	Rade Deguerre	Fixed accidentally triggering menus during bookmark search (Show More…)	Mar 23 2018, 6:44 PM
2841d0f45dc6	89f7723aa486	8d050ac98fd5 6fd0ed74d8d3	Nikita Melnichenko	Fixed bookmark search when started with S or J, improved menu style (Show More…)	Mar 23 2018, 4:34 AM
6fd0ed74d8d3	99c527591f5a	16befc43215b	Nikita Melnichenko	Made order of jump-back actions the same as in Go menu	Mar 22 2018, 4:44 AM
16befc43215b	7e07d0ee3019	f515bfa6b40a	Nikita Melnichenko	Fixed shortcuts for jump-back actions in bookmark menu	Mar 22 2018, 4:41 AM
f515bfa6b40a	8b9d3256c356	42858f0ea2c9	Nikita Melnichenko	Fixed jump-back actions in bookmark menu, improved separators (Show More…)	Mar 18 2018, 2:45 AM
8d050ac98fd5	d8dc17865141	2364a0106dd4	Yuri Chornoivan	Add the new option to Konfigurator docs	Mar 22 2018, 5:55 PM
2364a0106dd4	1e2e74874143	c1f2a3cb0bb1	Nikita Melnichenko	Added Konfigurator option to control bookmark search bar visibility (Show More…)	Mar 21 2018, 6:42 AM
c1f2a3cb0bb1	5e33a1fd6bf4	42858f0ea2c9	Rade Deguerre	Fixed key handling bug and added a QoL improvement (Show More…)	Mar 22 2018, 6:04 AM
42858f0ea2c9	aa4a82dbfedf	82da5a6d784b 059b9ef5bcae	Nikita Melnichenko	Improved match highlighting in the bookmark quick search (Show More…)	Mar 20 2018, 5:56 AM
059b9ef5bcae	aa4a82dbfedf	2eb7ee02e6be	Nikita Melnichenko	Deselect active item in case no match is found	Mar 17 2018, 8:19 PM
2eb7ee02e6be	0abe3f6bac72	82da5a6d784b	Nikita Melnichenko	Replaced underline hack with bold highlighting in the bookmark search (Show More…)	Mar 16 2018, 8:53 AM
82da5a6d784b	da2bf23c40a3	21900f61f34a f6cc251224f6	Nikita Melnichenko	Added quick search bar to the bookmark menu + various fixes (Show More…)	Mar 15 2018, 7:16 AM
f6cc251224f6	da2bf23c40a3	a39557553c79	Nikita Melnichenko	Fixed popular URLs container initialization order (Show More…)	Mar 13 2018, 4:45 AM
a39557553c79	dc790987c99c	84dc008285c3	Nikita Melnichenko	Fixed ownership of the quick search action	Mar 13 2018, 4:32 AM
84dc008285c3	f8e9e1c7d7a7	615bdd176227	Nikita Melnichenko	Removed outdated comments	Mar 11 2018, 8:45 AM
615bdd176227	990cc931176c	6632609e5493	Nikita Melnichenko	Added quick search bar to the bookmark menu (Show More…)	Mar 11 2018, 8:24 AM
6632609e5493	19af3d19cb1d	074851d8cd44	Nikita Melnichenko	Replaced ugly static variable with a proper design in bookmark menu builder	Mar 11 2018, 6:52 AM
074851d8cd44	7405f22a3229	21900f61f34a	Nikita Melnichenko	Fixed populating bookmark menu multiple times on startup (Show More…)	Mar 11 2018, 6:47 AM
21900f61f34a	31428e43d154	cb7711f8f6f8	Rade Deguerre	Add back quick search to the bookmark menu (Show More…)	Mar 8 2018, 4:14 AM