Details
- Reviewers
bcooksley - Maniphest Tasks
- T3689: Add abi compliance checker to CI
- Commits
- R857:4bc94fbefcb1: Extend Package capabilities to store additional metadata.
Diff Detail
- Repository
- R857 CI System Tooling
- Branch
- dev/T3689
- Lint
No Linters Available - Unit
No Unit Test Coverage
The Archive class in this case represents the whole repository, so having the extraMetadata stored at the instance level is probably incorrect here (as it belongs to the actual package itself)
Could we pass this as an argument to generateMetadataForFile / storePackage instead to keep it attached to just the package it belongs to?
This looks fine to me - not 100% sure about the GIT_COMMIT variable though.
| helpers/create-abi-dump.py | ||
|---|---|---|
| 283 ↗ | (On Diff #43851) | In a Jenkins Pipeline environment I believe this environment variable is never set, so to get the hash you'll need to shell out to Git unfortunately (git describe HEAD or git log --format=%H -n 1 HEAD are your friends here) |
| helpers/helperslib/Packages.py | ||
| 147 | pressed -> pre-seed? | |
| helpers/create-abi-dump.py | ||
|---|---|---|
| 283 ↗ | (On Diff #43851) | I just copied that part from capture-workspace.py and capture-install.py, so properly they are needed to be updated too. |
Thanks for those fixes, i'll get this landed.
| helpers/create-abi-dump.py | ||
|---|---|---|
| 283 ↗ | (On Diff #43851) | Yeah, at the moment our tooling doesn't rely on that metadata, but if we do need to make use of it in the future then we will need to fix that. |