Differential D11894

Show folder previews for items that have a Places Panel entry
ClosedPublic
Actions

Authored by ngraham on Apr 2 2018, 11:06 PM.

Details

Reviewers
markg
elvisangelaccio
Group Reviewers
Dolphin
Maniphest Tasks
T8349: Improve Places panel usability and presentation
Commits
R318:993c47f30923: Show folder previews for items that have a Places Panel entry
Summary

informationpanelcontent.cpp currently has an explicit check for whether or not a URL has a Places panel entry, and if it does, no folder preview is generated. It's not clear why this is done, but it was reported as a bug: https://bugs.kde.org/show_bug.cgi?id=392621. Removing the logic fixes the bug.

BUG: 392621
FIXED-IN: 18.08.0

Test Plan

Before:

After:

Detailed test procedure:

  • Open the Information Panel
  • Turn on previews
  • Put some pictures in ~/Pictures
  • Hover over it and see that the Information Panel shows a preview of its contents
  • Add ~/Pictures to the Places panel
  • Hover over it again and see that previews are no longer displayed
  • Apply the patch and restart Dolphin
  • Hover over it once more and see that there are now previews, yay!

Diff Detail

Repository
R318 Dolphin
Branch
show-folder-previews-for-items-that-have-places-panel-entries (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
ngraham requested review of this revision.Apr 2 2018, 11:06 PM
ngraham created this revision.
ngraham mentioned this in T8349: Improve Places panel usability and presentation.Apr 2 2018, 11:08 PM
ngraham retitled this revision from Show folder previwes for items that have a Places Panel entry to Show folder previews for items that have a Places Panel entry.
ngraham edited the test plan for this revision. (Show Details)Apr 2 2018, 11:24 PM
broulik added a subscriber: broulik.Apr 3 2018, 8:30 AM

I also can't find a reason, that has been in there with Dolphin's initial commit already. Perhaps it's just for making the folder icon more obvious and not have it cluttered with preview thumbs.

src/panels/information/informationpanelcontent.cpp
313–314

What about this one? (then this entire method could go)

ngraham updated this revision to Diff 31215.Apr 3 2018, 1:21 PM

Delete more unnecessary code

ngraham marked an inline comment as done.Apr 3 2018, 1:22 PM
markg accepted this revision.Apr 3 2018, 1:51 PM
markg added a subscriber: markg.

The only reason i can think of (but it's not that since it's not in the code) is to only do this for local drives, not network mounted drives.
But as that's not it, +1 :)

This revision is now accepted and ready to land.Apr 3 2018, 1:51 PM
ngraham closed this revision.Apr 3 2018, 10:39 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptSep 25 2018, 3:22 AM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript

Revision Contents
Changeset List

Diff 31215

View Options

src/panels/information/informationpanelcontent.h

Loading...
View Options

src/panels/information/informationpanelcontent.cpp

Loading...