- fix for https://bugs.kde.org/show_bug.cgi?id=392218
- fixed logical bug when files are removed and last file is current
- fixed current selection jumping to next file when current file is changed
- simplified code
Details
Details
- Reviewers
martinkostolny nmel - Group Reviewers
Krusader - Commits
- R167:2fbd49f01a89: Panel: Fixed unwanted scrolling and preserving current item on refresh
- tested current selection on panel startup
- tested current selection when going back in history
- tested preserving current and scrolling on manual refresh
- tested preserving current and scrolling when files are deleted
- tested preserving current and scrolling when files are added
- tested preserving current and scrolling when file is updated
- tested selecting current and scrolling when creating new dir
- tested selecting current when renaming file
Diff Detail
Diff Detail
- Repository
- R167 Krusader
- Branch
- my-fix-panel-current-on-refresh
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
Oh, fu... this seems to be a replacement for D11699. Didn't see this first, i just get too many mails recently.
Comment Actions
Hi Alex! Thanks for looking into this. You seem to have a complex patch that fixes more issues regarding the refreshing. I'll abandon D11699 in favour of this one.
However I've found a few drawbacks:
- going up in hierarchy or going back in history does not preserve current selection anymore
- current selection under currently refreshing file losts (even up/down arrows won't bring it back)
Comment Actions
- Panel: Fix current item not selected when going back in history
- Panel: Fix lost current if the previous item is removed
Comment Actions
Thanks for testing!
I thought I tested the first behaviour. But probably did changes after that :/
And the second one is strange, don't know exactly why the current is lost only in this particular case.