this prevents an excessive amount of coredumps being caused by pkcon
which sigquits the helper
Details
Details
- Reviewers
apol dantti - Commits
- R547:09927540b3d7: handle sigquit properly
debconf-kde-helper --socket-path=/tmp/gpk-26_baceaeca.socket kill -QUIT `pidof debconf-kde-helper
- no crash
Diff Detail
Diff Detail
- Repository
- R547 DebConf-KDE Library
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
AFAIK this is the wrong way of handling signals, don't recall exactly what the problem is, but Qt documentation says to create a pipe, attach a QSocketNotifier to it, and write data to it when the signal is caught, then the QSN signal will call qApp->quit();
Comment Actions
now signal-safe
- handler writes to one end of anon socket
- to the other is a QSocketNotifier attached
- QSN activates when handler writes -> we read the dummy data and quit
Comment Actions
QRegExp is only a change to the new/flat include style. Doesn't actually have anything to do with the fix. It's used in the main().