Adds the Action to flip the image vertically and horizontally
Needs ReviewPublic

Authored by ashivliving on Mar 12 2018, 6:36 PM.

Details

Reviewers
atulsharma
apol
mart
Group Reviewers
Koko
Summary

Added options to flip the image vertically and horizontally in the right-hand drawer.

Diff Detail

Repository
R659 Koko Image Gallery
Lint
Lint Skipped
Unit
Unit Tests Skipped
ashivliving requested review of this revision.Mar 12 2018, 6:36 PM
ashivliving created this revision.
apol requested changes to this revision.Mar 13 2018, 12:01 AM
apol added a subscriber: apol.
apol added inline comments.
src/imagedocument.cpp
91

Why are you doing that? looks redundant and unnecessary.

src/imagedocument.h
44

This const doesn't add any information, remove.
Needs at least documentation, what's flipVertical(false)? maybe turn the bool into an enum?

This revision now requires changes to proceed.Mar 13 2018, 12:01 AM

Removed const and changed bool to enum for the image flip and remove ambiguous function into a general "flip" function.

mart accepted this revision.May 14 2018, 9:05 AM