Do not leak symbols of pimpl classes, protect with Q_DECL_HIDDEN
ClosedPublic
Actions

Authored by kossebau on Mar 10 2018, 1:37 PM.

Details

Reviewers

graesslin
davidedmundson

Commits

Summary

Nested classes inherit the visibility of their outer class,
so all the KClass::Private symbols have also been exported
if the ones of KClass were

Repository

R129 Window Decoration Library

Branch

donotleakpimplsymbols

Lint

No Linters Available

Unit

No Unit Test Coverage

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

kossebau requested review of this revision.Mar 10 2018, 1:37 PM

This revision is now accepted and ready to land.Mar 20 2018, 1:27 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/decoration_p.h (2 lines)
M			src/decorationbutton_p.h (2 lines)
M			src/decorationbuttongroup_p.h (2 lines)
M			src/decorationshadow_p.h (2 lines)
M			src/private/decoratedclientprivate.cpp (2 lines)
M			src/private/decorationsettingsprivate.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	29154	19f0055		Mar 10 2018, 1:37 PM	★	★
Diff 2	30068	19f0055	R129:05b3b8b6d3355e4a61284a7458055b4ead50a7b3	Mar 20 2018, 11:15 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
fe540f8d43e2	78bbd1ed306b	19f005507709	Friedrich W. H. Kossebau	Do not leak symbols of pimpl classes, protect with Q_DECL_HIDDEN (Show More…)	Mar 10 2018, 1:33 PM