Differential D11149

Create a constructor for KLocalizedStringPrivate
ClosedPublic
Actions

Authored by jtamate on Mar 8 2018, 8:16 AM.

Details

Reviewers
ilic
Group Reviewers
Frameworks
Commits
R249:a02e99069e15: Create a constructor for KLocalizedStringPrivate
Summary

The constructor avoids the following asan runtime errors
kdesrc/frameworks/ki18n/src/klocalizedstring.cpp:179:7: runtime error: load of value 3200171710, which is not a valid value for type 'VisualFormat'
kdesrc/frameworks/ki18n/src/klocalizedstring.cpp:179:7: runtime error: load of value 190, which is not a valid value for type 'bool'
kdesrc/frameworks/ki18n/src/klocalizedstring.cpp:179:7: runtime error: load of value 190, which is not a valid value for type 'bool'
kdesrc/frameworks/ki18n/src/klocalizedstring.cpp:179:7: runtime error: load of value 190, which is not a valid value for type 'bool'

Test Plan

start konsole

Diff Detail

Repository
R249 KI18n
Lint
Lint Skipped
Unit
Unit Tests Skipped
jtamate created this revision.Mar 8 2018, 8:16 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 8 2018, 8:16 AM
jtamate requested review of this revision.Mar 8 2018, 8:16 AM
ilic added a subscriber: ilic.Mar 8 2018, 8:45 AM
ilic added inline comments.
src/klocalizedstring.cpp
202–204

Should have space after colon/comma?

jtamate updated this revision to Diff 28990.Mar 8 2018, 8:53 AM

With spaces after : and ,

ilic accepted this revision.Mar 8 2018, 9:01 AM
This revision is now accepted and ready to land.Mar 8 2018, 9:01 AM
Closed by commit R249:a02e99069e15: Create a constructor for KLocalizedStringPrivate (authored by jtamate). · Explain WhyMar 8 2018, 6:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/klocalizedstring.cpp (8 lines)

Diff 28990

View Options

src/klocalizedstring.cpp

Loading...