ToolbarApplicationHeader layout
ClosedPublic
Actions

Authored by mart on Mar 7 2018, 4:44 PM.

Details

Reviewers

apol

Group Reviewers

Kirigami

Commits

Summary

layout, based on some kmail mockups as follows:

Test Plan

attached some screenshots on how it works in several different cases

Repository

R169 Kirigami

Branch

phab/toolbartweak

Lint

No Linters Available

Unit

No Unit Test Coverage

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

mart requested review of this revision.Mar 7 2018, 4:44 PM

mart changed the visibility from "Public (No Login Required)" to "No One".Mar 7 2018, 4:44 PM

mart retitled this revision from some layouting tweaks to ToolbarApplicationHeader layout.Mar 7 2018, 4:48 PM

mart edited the summary of this revision. (Show Details)

mart edited the test plan for this revision. (Show Details)

mart added a reviewer: Kirigami.

mart changed the visibility from "No One" to "Public (No Login Required)".Mar 7 2018, 4:55 PM

+1, this is a huge visual improvement in my eyes.

apol accepted this revision.Mar 7 2018, 5:27 PM

apol added a subscriber: apol.

apol added inline comments.

src/styles/org.kde.desktop/Units.qml
101	Unrelated change.

This revision is now accepted and ready to land.Mar 7 2018, 5:27 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/controls/ToolBarApplicationHeader.qml (75 lines)
M			src/controls/private/PrivateActionToolButton.qml (2 lines)
M			src/controls/templates/AbstractListItem.qml (8 lines)
M			src/controls/templates/ApplicationHeader.qml (2 lines)
M			src/styles/org.kde.desktop/Units.qml (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	28956	988cb45		Mar 7 2018, 4:44 PM	★	★
Diff 2	28960	988cb45	- paddings fixes	Mar 7 2018, 5:01 PM	★	★
Diff 3	28963	988cb45	R169:2e7ec021ad0e0cf8e05012e1465a08d6960af252	Mar 7 2018, 5:28 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
0ef511c0b15a	d8170d644994	47dd6d9729cf	Marco Martin	paddings fixes	Mar 7 2018, 5:01 PM
47dd6d9729cf	925b52f6dbe1	988cb45a2ce8	Marco Martin	some layouting tweaks (Show More…)	Mar 7 2018, 4:43 PM