Improve overall look according to bug report and mockup.
BUG: 390280
andreask | |
broulik |
Plasma |
Improve overall look according to bug report and mockup.
BUG: 390280
No Linters Available |
No Unit Test Coverage |
applets/mediacontroller/contents/ui/ExpandedRepresentation.qml | ||
---|---|---|
290 | Pls tell me a way to use Headings without huge margins all around. |
Cool!
applets/mediacontroller/contents/ui/ExpandedRepresentation.qml | ||
---|---|---|
123 | Math.round | |
124 | Why is this thing no longer in a ColumLayout? | |
188 | cnthrwueif..what? | |
290 | height: undefined | |
301 | Add braces | |
303 | return root.artist ? i18nc("artist - track", "%1 – %2", root.artist, root.track) : root.track | |
311 | Why not use a ColumnLayout? | |
312 | I thought level only went up to 5 but fine with me | |
318 | So you now use the file name as "album"? How does it behave when you have no id3 info at all? | |
358 | Not neccessary, that item is full width already |
applets/mediacontroller/contents/ui/ExpandedRepresentation.qml | ||
---|---|---|
124 | I want to have the controls always at the same fixed position at the bottom of the applet. With a layout it would shift them around according to the content available (which you can probably block somehow, but I couldn't really get it to work and using anchors or simple columns to achieve this seems more straightforward to me anyway). | |
290 | If I forget this trick one more time, hit me. | |
311 | As above. I want to have this stuff always at fixed positions. Or is there a simple way to achieve this with Layouts as well? | |
312 | Yea, you're right. It just interprets everything above 5 as 5. | |
318 | I don't have changed anything in this regard. |
Not sure if it is within the scope of this patch but the spacing is uneven vertically between elements in the notification window. They need more space to breathe.
Media Player
Cover Artwork
Progress Bar
Song Title
Media Controls
Window bottom edge
It should be:
Media Player
Cover Artwork
Progress Bar
Song Title
Media Controls
Window bottom edge
IMHO that would be way too much whitespace. We already get a lot of user complaints that Plasma widgets and menus have excessive padding and whitespace.
Go go go :)
applets/mediacontroller/contents/ui/ExpandedRepresentation.qml | ||
---|---|---|
174 | usesPlasmaTheme: false |