Migration request from IBusConfig to GSettings
ClosedPublic

Authored by fujiwara on Mar 5 2018, 2:39 PM.

Details

Summary

kimpanel-ibus-panel uses IBusConfig and I'd ask to migrate it to GSettings and delete IBusConfig.

https://groups.google.com/forum/#!topic/ibus-devel/Mu1IoFX-bKE

Test Plan

Run ibus-setup and changes "Next input method" or IMEs and KIM panel works fine.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
fujiwara created this revision.Mar 5 2018, 2:39 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 5 2018, 2:39 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
fujiwara requested review of this revision.Mar 5 2018, 2:39 PM

May I ask when this gsettings is introduced? Is it required after certain ibus version? Is there any case that this will not work?

If so I'd like to see a version check on ibus at compile time.

May I ask when this gsettings is introduced? Is it required after certain ibus version? Is there any case that this will not work?

If so I'd like to see a version check on ibus at compile time.

GSettings has been supported in IBus 1.5.0 at least and you don't have to mind IBus.

xuetianweng added inline comments.Mar 6 2018, 3:43 AM
applets/kimpanel/backend/ibus/ibus15/panel.cpp
1031

IMHO you need to g_object_unref this two new settings in ibus_panel_impanel_destroy.

1033

and disconnect the signal too.

xuetianweng requested changes to this revision.Mar 6 2018, 3:43 AM
This revision now requires changes to proceed.Mar 6 2018, 3:43 AM
fujiwara planned changes to this revision.Mar 6 2018, 8:30 AM
fujiwara updated this revision to Diff 28793.
fujiwara marked 2 inline comments as done.
fujiwara requested review of this revision.Mar 6 2018, 8:32 AM

FWIW, there's a lovely Qt-GConf wrapper in plasma-pa/gconfitem

FWIW, there's a lovely Qt-GConf wrapper in plasma-pa/gconfitem

imho, this is pretty irrelevant here.. gsettings is not directly gconf and gconf itself is deprecated since gtk3 iirc.

xuetianweng requested changes to this revision.Mar 6 2018, 12:50 PM
xuetianweng added inline comments.
applets/kimpanel/backend/ibus/ibus15/panel.cpp
1049

I think you can use g_clear_object here.

This revision now requires changes to proceed.Mar 6 2018, 12:50 PM
fujiwara updated this revision to Diff 28881.Mar 7 2018, 2:14 AM
fujiwara marked an inline comment as done.

FWIW, there's a lovely Qt-GConf wrapper in plasma-pa/gconfitem

I may drop gconf and dconf support in IBus 1.6. It would be nice if Qt API could read GSettings.

xuetianweng added inline comments.Mar 7 2018, 9:25 AM
applets/kimpanel/backend/ibus/ibus15/panel.cpp
922
933

Same as above

fujiwara updated this revision to Diff 28920.Mar 7 2018, 11:35 AM
fujiwara marked 2 inline comments as done.
xuetianweng accepted this revision.Mar 7 2018, 5:25 PM
This revision is now accepted and ready to land.Mar 7 2018, 5:25 PM
This revision was automatically updated to reflect the committed changes.

Not so sure why phabricator didn't set you as the commit author... sorry about that.