Make Webkit optional
ClosedPublic

Authored by heikobecker on Feb 28 2018, 6:17 PM.

Details

Reviewers
markey
Group Reviewers
Amarok
Commits
R181:d65ce101313e: Make Webkit optional
Summary

Qt4Webkit is old, utterly unmaintained and insecure. Quite a number
of distros have abandoned it or are in the process of doing so.
If the option is disabled the Wikipedia and Info context applets
aren't available (as well as the Upcoming events one in combination
with LastFM).

Test Plan

Successfully built with -DWITH_QTWEBKIT=TRUE/FALSE

Diff Detail

Repository
R181 Amarok
Branch
webkit-optional
Lint
No Linters Available
Unit
No Unit Test Coverage
heikobecker created this revision.Feb 28 2018, 6:17 PM
Restricted Application added a project: Amarok. · View Herald TranscriptFeb 28 2018, 6:17 PM
heikobecker requested review of this revision.Feb 28 2018, 6:17 PM
markey added a subscriber: markey.Feb 28 2018, 6:20 PM

Is this patch meant for master? Because the branch is "webkit-optional".

Is this patch meant for master? Because the branch is "webkit-optional".

Yes, I just had a local branch for arc diff because I have multiple unrelated commits which aren't pushed yet.

markey accepted this revision.Mar 5 2018, 7:48 PM
This revision is now accepted and ready to land.Mar 5 2018, 7:48 PM
markey closed this revision.Mar 5 2018, 7:48 PM