Differential D1160

filetemplates plugin: Make testfiletemplates depend on kdevfiletemplates
ClosedPublic
Actions

Authored by rakuco on Mar 17 2016, 12:40 PM.

Details

Reviewers
mwolff
kfunk
arrowd
Group Reviewers
KDevelop
Commits
R33:dd18e9a13558: filetemplates plugin: Make testfiletemplates depend on kdevfiletemplates
R32:dd18e9a13558: filetemplates plugin: Make testfiletemplates depend on kdevfiletemplates
Summary

There is currently no dependency between both targets, however some of the files built by both testfiletemplates and kdevfiletemplates (such as classidentifierpage.cpp) depend on ui files that only the latter target generates. This means that if one does make testfiletemplates the build fails like this:

/tmp/kdevplatform/plugins/filetemplates/classidentifierpage.cpp:23:25: fatal error: ui_newclass.h: No such file or directory

Diff Detail

Repository
R33 KDevPlatform
Lint
Lint Skipped
Unit
Unit Tests Skipped
rakuco updated this revision to Diff 2817.Mar 17 2016, 12:40 PM
rakuco retitled this revision from to filetemplates plugin: Make testfiletemplates depend on kdevfiletemplates.
rakuco updated this object.
rakuco edited the test plan for this revision. (Show Details)
rakuco added a reviewer: KDevelop.
rakuco set the repository for this revision to R33 KDevPlatform.
rakuco added a project: KDevelop.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptMar 17 2016, 12:40 PM
arrowd added inline comments.Mar 17 2016, 1:19 PM
plugins/filetemplates/CMakeLists.txt
81

I guess, it is possible to just include ${CMAKE_CURRENT_BINARY_DIR}/ui_newclass.h in test_srcs. But i'm not sure what is cleaner.

kfunk accepted this revision.Mar 17 2016, 1:24 PM
kfunk edited edge metadata.

Ah, gotcha. Not the cleanest approach, but it'll do for now. (I'd rather turn the source files which are compiled twice in a static lib.)

Please push to *1.7* branch (someone reported this issue for the 1.7 series as well)

This revision is now accepted and ready to land.Mar 17 2016, 1:24 PM
Closed by commit R33:dd18e9a13558: filetemplates plugin: Make testfiletemplates depend on kdevfiletemplates (authored by rakuco). · Explain WhyMar 17 2016, 2:35 PM
This revision was automatically updated to reflect the committed changes.
rakuco added a comment.Mar 17 2016, 2:35 PM

I've committed this to the 1.7 branch, with the required changes. Will you guys merge it to 5.0 or should I take care of it?

kfunk added a comment.Mar 17 2016, 2:43 PM

We'll take care of it

Revision Contents
Changeset List

Diff 2817

View Options

plugins/filetemplates/CMakeLists.txt

Loading...