Improve sidebar header visibility
ClosedPublic

Authored by ngraham on Feb 18 2018, 3:16 AM.

Details

Summary

BUG: 384638
FIXED-IN: KDE Plasma 5.12.2

System Settings' sidebar headers were implemented as orginary Kirigami list items that had enabled: false set, which made them turn an almost unreadable light color. This a hack; it should have used real headers. And it was the wrong hack, as evidenced by the visual breakage.

This patch changes the hack to a different one that works much better. Ideally we would use real Kirigami list headers here, but the current system settings implementation seems to make this a challenge and I'm not sure it's worth it. Willing to be proven wrong, though.

Test Plan

Before, primary category headers, Breeze light:

After, primary category headers, Breeze light:

Before, sub-category headers, Breeze light:

After, sub-category headers, Breeze light:

Before, primary category headers, Breeze dark:

After, primary category headers, Breeze dark:

Before, sub-category headers, Breeze dark:

After, sub-category headers, Breeze dark:

Diff Detail

Repository
R124 System Settings
Branch
more-visible-headers (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
ngraham created this revision.Feb 18 2018, 3:16 AM
Restricted Application added projects: Plasma, Kirigami. · View Herald TranscriptFeb 18 2018, 3:16 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Feb 18 2018, 3:16 AM
ngraham edited the summary of this revision. (Show Details)Feb 18 2018, 3:20 AM
ngraham edited the test plan for this revision. (Show Details)
rkflx added a subscriber: rkflx.Feb 18 2018, 8:20 AM

Note that for the light theme this changes the background colour from #FCFCFC to #FFFFFF.

Oh shoot, I hadn't noticed that. :(

mart added a comment.Feb 19 2018, 9:36 AM

I'm ok with making the text darker in the headers.
I'm not exactly sure why as viewbackgroundcolor should be correct(tough deprecated), but in the breeze light screenshots the headers have a background slightly ligher than the other elements, which makes it look a bit weird

sidebar/package/contents/ui/CategoriesPage.qml
134

hoverEnabled: false should be enough (iirc there are also properties to make it not do mousepressed effects)

mart added inline comments.Feb 19 2018, 9:38 AM
sidebar/package/contents/ui/CategoriesPage.qml
134

should be supportsMouseEvents: false

ngraham updated this revision to Diff 27539.Feb 19 2018, 1:38 PM

Use supportsMouseEvents: false instead

ngraham edited the test plan for this revision. (Show Details)Feb 19 2018, 1:38 PM
ngraham updated this revision to Diff 27540.Feb 19 2018, 1:45 PM
ngraham marked 2 inline comments as done.

Also improve subcategory headers

ngraham edited the test plan for this revision. (Show Details)Feb 19 2018, 1:48 PM
mart accepted this revision.Feb 19 2018, 2:48 PM
This revision is now accepted and ready to land.Feb 19 2018, 2:48 PM
ngraham updated this revision to Diff 27550.Feb 19 2018, 3:05 PM

re-base on Plasma 5.12 branch

ngraham closed this revision.Feb 19 2018, 3:06 PM