I seem to be able to click through a SwipeListItem's delegate and trigger actions that should be out of reach. There are probably better ways to do this but this fixes it for me.
Details
Details
- Reviewers
mart - Group Reviewers
Kirigami - Commits
- R169:d7c5c1ac6dda: Don't trigger SwipeListItem's actions unless they are exposed
Diff Detail
Diff Detail
- Repository
- R169 Kirigami
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
Can you explain a bit better the issue?
Why aren't they exposed? what do you mean by exposing them?
Why is x false?
Comment Actions
the issue is valid, i'm not sure a check of the item x is a good enough assumption.
in what conditions this click trough happens? i can't seem to be able to reproduce
Comment Actions
@mart It's quite reproducible. Start kirigami gallery (I did it on Android) -- go into 'list view' -- bunch of SwipeListItems there -- tap somewhere to the left of the 'swipe icon' (the one you're supposed to drag left) --- you will trigger either action 1 or 2 as evidenced by the notification.
@apol background.x is 0 when the item is not 'swiped' to the left and the action icons are therefore not exposed.
Comment Actions
that's how i did it locally tough still need fixes
Item {
id: behindItem parent: listItem z: -1 //TODO: a global "open" state enabled: background.x !== 0
do you want to push this yourself?