BUG: 390499
Details
Details
- Reviewers
broulik jtamate - Group Reviewers
Plasma - Commits
- R120:53ed39aaa477: Micro-optimise screenpool event filter by caching xcb extension offset
See callgrind in bug report
Added debug in the relevant section, unplugged a monitor. Saw my output
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage
shell/screenpool.cpp | ||
---|---|---|
44 | Needs x11 guard |
Comment Actions
since the two watched things are screen added and primary screen changed, couldn't the signals be used instead?
i vaguely remember back when i implemented it something about the signals arriving "too late", may this be correct? (and if so, it should go in the comments)
Comment Actions
You do have a comment :)
// we don't have any signal about it, the primary screen changes but we have the same old QScreen* getting recycled
shell/screenpool.cpp | ||
---|---|---|
44 | Shouldn't it be a #if HAVE_X11? |
Comment Actions
Even the number of calls registered are less, now most of the time is spent doing the eventType != "xcb_generic_event_t".