Differential D10498

Workaround the touchpad toggle button not working
ClosedPublic
Actions

Authored by aacid on Feb 14 2018, 12:03 AM.

Details

Reviewers
davidedmundson
xuetianweng
Commits
R119:2b098f69d354: Workaround the touchpad toggle button not working
Summary

BUGS: 370588

Test Plan

Without it the touchpad toggle at my laptop just toggles once
now it works fine all the time

Diff Detail

Repository
R119 Plasma Desktop
Branch
arcpatch-D10498
Lint
No Linters Available
Unit
No Unit Test Coverage
aacid created this revision.Feb 14 2018, 12:03 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 14 2018, 12:03 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
aacid requested review of this revision.Feb 14 2018, 12:03 AM
aacid updated this revision to Diff 27123.Feb 14 2018, 12:10 AM
aacid edited the summary of this revision. (Show Details)

[try to] add BUGS:

aacid updated this revision to Diff 27125.Feb 14 2018, 12:12 AM

correct diff against Plasma/5.12

xuetianweng added a comment.Feb 14 2018, 12:15 AM

Emm, mind to get rid of the .desktop part for this review?

Also I think you need to give some explanation about why this works.

xuetianweng accepted this revision.Feb 14 2018, 12:17 AM

Oh, ok.. now the diff looks normal.

This revision is now accepted and ready to land.Feb 14 2018, 12:17 AM
aacid updated this revision to Diff 27126.Feb 14 2018, 12:19 AM

better? explanation of why the workaround works

aacid added a comment.Feb 14 2018, 12:20 AM

I updated the comment, can you have a look and approve again?

xuetianweng accepted this revision.Feb 14 2018, 12:20 AM

I sent the comment before you corrected the diff branch. LGTM.

knambiar added a subscriber: knambiar.Feb 14 2018, 6:01 AM

+1.
I've also spent some time debugging this issue, and was perplexed why the property change event doesn't propagate. This fix should be backported if possible.

aacid closed this revision.Feb 14 2018, 11:52 PM

Revision Contents
Changeset List

Diff 27125

View Options

kcms/touchpad/src/backends/x11/xlibbackend.cpp

Loading...