Differential D9843

Fix token page URL
ClosedPublic
Actions

Authored by davidk on Jan 12 2018, 3:02 PM.

Details

Reviewers
dvratil
mlaurent
Commits
R477:fa572d93cfa4: Fix token page URL
R477:2980ace5fc69: Fix token page URL
Summary

It seems like Google changed the URL of the token page.
Maybe we should use QString::startsWith, to be futureproof?

BUG: 388483

Test Plan
  • Login in KOrganizer and KMail works again
  • All tests pass (though i think there is no oauth2 test)

Diff Detail

Repository
R477 KGAPI Library
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
davidk requested review of this revision.Jan 12 2018, 3:02 PM
davidk created this revision.
mlaurent added a comment.Jan 12 2018, 6:36 PM

It's good if it logs now.
But where do you find info about new url ?

davidk added a comment.Jan 12 2018, 6:45 PM
In D9843#190037, @mlaurent wrote:

It's good if it logs now.
But where do you find info about new url ?

I got the info by adding debug output. I didn't find any official info about it, probably because it's an implementation detail which we shouldn't depend on.
The only reference i cound find, was some microsoft bug report.

mlaurent accepted this revision.Jan 13 2018, 8:34 AM

Yep I investigated too and it seems that it's the solution see ""https://github.com/VBA-tools/VBA-Web/issues/290"

This revision is now accepted and ready to land.Jan 13 2018, 8:34 AM
davidk updated this revision to Diff 25265.Jan 13 2018, 12:27 PM

Remove question in commit message

Closed by commit R477:2980ace5fc69: Fix token page URL (authored by davidk). · Explain WhyJan 13 2018, 12:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/core/ui/authwidget_p.h (2 lines)

Diff 25265

View Options

src/core/ui/authwidget_p.h

Loading...