Differential D9476

Fix duplicate authentication
ClosedPublic
Actions

Authored by fvogt on Dec 22 2017, 10:56 AM.

Details

Reviewers
mlaurent
dvratil
Commits
R733:ec2afd27c790: Fix duplicate authentication
Summary

The response to EHLO triggers an authentication command, but with TLS
two EHLOs are sent: For the 220 from the server and after TLS negotiation.
However, sending it twice results in an unexpected "503 already authenticated"
response which ends up getting parsed by the SendJob, causing confusion.

BUG: 387926
BUG: 388068

Diff Detail

Repository
R733 KSmtp
Branch
Applications/17.12
Lint
No Linters Available
Unit
No Unit Test Coverage
fvogt requested review of this revision.Dec 22 2017, 10:56 AM
fvogt created this revision.
lbeltrame added a project: KDE PIM.Dec 22 2017, 10:58 AM
lbeltrame added a subscriber: KDE PIM.
krop added a comment.Dec 22 2017, 11:00 AM

Tested successfully with 5 different SMTP servers with both SSL and TLS.

fvogt added a comment.Dec 22 2017, 11:00 AM

This should probably be fixed differently: Retriggering the EHLO-resend in encryptionNegotiationResult instead of in SessionThread.

I'm not sure how to do that without code duplication however. It would then also respect the customHostname setting.

asn added a subscriber: asn.Dec 22 2017, 11:04 AM
fvogt updated this revision to Diff 24284.Dec 22 2017, 11:18 AM

Move the resending to SessionPrivate. Also uses the correct hostname now.

dvratil added a comment.Dec 23 2017, 11:48 AM

Looks good, thank you!

Please commit to Applications/17.12 branch.

dvratil accepted this revision.Dec 23 2017, 11:48 AM
This revision is now accepted and ready to land.Dec 23 2017, 11:48 AM
Closed by commit R733:ec2afd27c790: Fix duplicate authentication (authored by fvogt). · Explain WhyDec 23 2017, 12:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/session.cpp (29 lines)
Msrc/session_p.h (1 line)
Msrc/sessionthread.cpp (1 line)

Diff 24284

View Options

src/session.cpp

Loading...
View Options

src/session_p.h

Loading...
View Options

src/sessionthread.cpp

Loading...