Differential D9365

Add test cases for rocketchataccountsettings
AbandonedPublic
Actions

Authored by velurimithun on Dec 17 2017, 5:50 AM.

Details

Reviewers
mlaurent
Summary

Test all the default values and signals using QSignalSpy.
Assign and get verifications for methods in rocketchataccountsettings class.

Test Plan
  • Methods returning QString should return an empty string.
  • Check all the signals using QSIgnalSpy when they are triggered.
  • Add tests for all the set and get methods.

Diff Detail

Repository
R865 Ruqola
Lint
Lint Skipped
Unit
Unit Tests Skipped
velurimithun requested review of this revision.Dec 17 2017, 5:50 AM
velurimithun created this revision.
mlaurent added inline comments.Dec 17 2017, 8:55 AM
autotests/rocketchataccountsettingstest.cpp
41

create it on stack

53

split in other method

57

use new connect api

58

no I don't know if emitting signal will provide a valid signal :)

I need to know if when I assign a value it will be emit

mlaurent requested changes to this revision.Dec 17 2017, 11:23 AM
This revision now requires changes to proceed.Dec 17 2017, 11:23 AM
velurimithun updated this revision to Diff 24029.Dec 17 2017, 3:34 PM
  • default userId fails after loadSettings() is called.
  • it seems like logout() doesn't emit a signal.
  • reference to a signal is used instead connect as used in typingnotificationtest.cpp
mlaurent added a comment.Dec 17 2017, 4:07 PM

Please test "setAccountName"/accountName (assign/get value is the same)
Same for other settings

autotests/rocketchataccountsettingstest.cpp
25

Remove it.

33

coding style: new line after ()

39

REmove it

44

new line

50

Remove it

71

if it doesn't emit signal "SpyLoginStatus.count()" can't be equal to 1 no ?

> test failed no ?

86

Stack == create RocketChatAccount as "socketChatAccountSettings setting;
not using QStack :)

99

REmove it

velurimithun updated this revision to Diff 24032.Dec 17 2017, 5:58 PM
velurimithun retitled this revision from defaultValues test case for rocketchataccountsettings to Add test cases for rocketchataccountsettings .
velurimithun edited the summary of this revision. (Show Details)
velurimithun edited the test plan for this revision. (Show Details)

Add tests for all methods in rocketchataccountsettings.

mlaurent added inline comments.Dec 17 2017, 6:33 PM
autotests/rocketchataccountsettingstest.cpp
81

create temps variable as const QString val = QStringLiteral("...")
do you can write setAccountName(val);

QCOMPARE(accountName(), val);

same for other methods

velurimithun updated this revision to Diff 24050.Dec 18 2017, 2:12 AM

Pass QStringLiteral via temp variable for all the methods.

velurimithun added a comment.Dec 18 2017, 2:15 AM

Done!

Thank you.

Regards.

mlaurent added a comment.Dec 18 2017, 5:43 AM

Where is the full patch ?
Why you don't use arc diff for updating patch ?

Revision Contents
Changeset List

Diff 24029

View Options

autotests/rocketchataccountsettingstest.h

Loading...
View Options

autotests/rocketchataccountsettingstest.cpp

Loading...