Test all the default values and signals using QSignalSpy.
Assign and get verifications for methods in rocketchataccountsettings class.
Details
Details
- Reviewers
mlaurent
- Methods returning QString should return an empty string.
- Check all the signals using QSIgnalSpy when they are triggered.
- Add tests for all the set and get methods.
Diff Detail
Diff Detail
- Repository
- R865 Ruqola
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
- default userId fails after loadSettings() is called.
- it seems like logout() doesn't emit a signal.
- reference to a signal is used instead connect as used in typingnotificationtest.cpp
Comment Actions
Please test "setAccountName"/accountName (assign/get value is the same)
Same for other settings
autotests/rocketchataccountsettingstest.cpp | ||
---|---|---|
25 | Remove it. | |
33 | coding style: new line after () | |
39 | REmove it | |
44 | new line | |
50 | Remove it | |
71 | if it doesn't emit signal "SpyLoginStatus.count()" can't be equal to 1 no ? > test failed no ? | |
86 | Stack == create RocketChatAccount as "socketChatAccountSettings setting; | |
99 | REmove it |
autotests/rocketchataccountsettingstest.cpp | ||
---|---|---|
81 | create temps variable as const QString val = QStringLiteral("...") QCOMPARE(accountName(), val); same for other methods |