Add an inverse button to level filter widget
ClosedPublic

Authored by wuweilin on Nov 29 2017, 2:13 PM.

Details

Summary

BUG 375842

Add an inverse button to level filter widget such that positions
of the black and the white cursor can be swapped.
Add 'inverted' field to KisGradientSlider. In inverted mode,
gradients are drawn in the reverse order, from white to black.
Fix confusing representation of coordinates of cursor in
KisGradientSlider

Signed-off-by: Wuwei Lin <vincentl13x@gmail.com>

Diff Detail

Repository
R37 Krita
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
wuweilin requested review of this revision.Nov 29 2017, 2:13 PM
wuweilin created this revision.
rempt accepted this revision.Dec 3 2017, 2:51 PM
rempt added a subscriber: rempt.

I've only got a little, very minor coding standards niggle. For the rest, this works fine. I've also tested saving a kra file with an adjustment layer with inverted levels, and that is fine as well.

plugins/filters/levelfilter/kis_level_filter.cpp
221–225

Our coding standards want {} even around one line statements.

This revision is now accepted and ready to land.Dec 3 2017, 2:51 PM
wuweilin updated this revision to Diff 23481.Dec 5 2017, 8:09 AM

Fix coding style issue

rempt added a comment.Dec 5 2017, 8:18 AM

Do you have push access already, or should we push the patch for you?

In D9052#176048, @rempt wrote:

Do you have push access already, or should we push the patch for you?

No, please help me about that. Thanks.

This revision was automatically updated to reflect the committed changes.