The previous icons were old (pre-Material, maybe even pre-Holo). The recommended practice now is to add the icons directly to your app, so I added the material icons. Note that the vector version is used; these are automatically converted to bitmaps for older android versions.
Details
Details
- Reviewers
- None
- Group Reviewers
KDE Connect - Commits
- R225:044261ceb1fd: Use material icons in MPRIS activity
Diff Detail
Diff Detail
- Repository
- R225 KDE Connect - Android application
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
+1 for these reviews it's usually better to send a picture to see what it looks like.
Comment Actions
Resolved conflicts because of D8942
Any further comments? If not, can somebody merge this?
Comment Actions
Don't you need to add some additional gradle step for vector icons to be converted to bitmaps? Is that the default behaviour? I just want to be sure we won't break the app on old devices :)
Comment Actions
It's the default behaviour (see https://developer.android.com/studio/write/vector-asset-studio.html).
To be sure, I checked the generated APK, and it does contain the raster images.