Use software backend for welcome page
ClosedPublic
Actions

Authored by brauch on Nov 17 2017, 5:34 PM.

Details

Reviewers

Commits

Summary

We really don't need to use OpenGL for drawing 3 buttons and a grey background. Using the software renderer should

Test Plan

Seems to work fine and doesn't feel slow or anything.

Repository

R32 KDevelop

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

I like the idea.

The only problems I see is:

This needs Qt 5.8 (should be ifdef'ed)
This call should probably be moved into main(), even if that means linking kdevelop against Qt5::Quick. This static function call affects the whole application and if we're doing this too late other components may initialize a quick window using the OpenGL backend already. (Think of KCMs being implemented in QtQuick, etc.)

Opinions?

This revision is now accepted and ready to land.Nov 17 2017, 6:36 PM

kfunk requested changes to this revision.Nov 17 2017, 6:36 PM

This revision now requires changes to proceed.Nov 17 2017, 6:36 PM

Yes, makes sense to me.

LGTM, thanks a lot!

app/main.cpp
310	Please add a comment explaining why we're doing this, and probably point to bug 386527.

This revision is now accepted and ready to land.Nov 17 2017, 6:55 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			app/CMakeLists.txt (2 lines)
M			app/main.cpp (9 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	22538			Nov 17 2017, 5:32 PM	★	★
Diff 2	22541			Nov 17 2017, 6:43 PM	★	★
Diff 3	22542	37a11f9	R32:49b5df418539b97137c2a9c63fa3ce139908e420	Nov 17 2017, 7:00 PM	★	★