Make status bar a bit smaller.
ClosedPublic

Authored by kkasper on Nov 15 2017, 5:53 PM.

Details

Test Plan

Clicking a button on the status bar shows that all labels are still visible.

Diff Detail

Repository
R344 Juk
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
kkasper created this revision.Nov 15 2017, 5:53 PM
mpyne accepted this revision.Nov 17 2017, 2:59 AM

The change is good (and looks better as well) but please change the type of the QWidget *parent in the StatusBar constructor before committing.

statuslabel.cpp
58–59

I like it, but I'd rather change the QWidget *parent parameter to be a QStatusBar *statusBar than to have a static_cast here. JuK controls the type of this parameter so there's no need to leave it as a QWidget if it has to be something else.

This revision is now accepted and ready to land.Nov 17 2017, 2:59 AM
kkasper updated this revision to Diff 22539.Nov 17 2017, 6:28 PM

Change parent type to QStatusBar.

mpyne accepted this revision.Nov 18 2017, 12:47 AM

Looks good, please commit.

This revision was automatically updated to reflect the committed changes.