fix "none" being set as default compiler on windows
ClosedPublic
Actions

Authored by geetamc on Nov 13 2017, 11:01 PM.

Details

Reviewers

mwolff

Commits

Summary

and as a result, fix standard msvc include directories not being provided to the language plugin.

Repository

R32 KDevelop

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

idea lgtm in general, but please cleanup the implementation

plugins/custom-definesandincludes/compilerprovider/compilerprovider.cpp
182	use http://doc.qt.io/qt-5/qdir.html#listSeparator i.e.: const auto path = QFile::decodeName(rt->getenv("PATH")) .split(QDir::listSeparator());

This revision now requires changes to proceed.Nov 14 2017, 9:46 AM

lgtm, will push to 5.2

This revision is now accepted and ready to land.Nov 15 2017, 10:27 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			plugins/custom-definesandincludes/compilerprovider/compilerprovider.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	22298	7c7180a		Nov 13 2017, 11:01 PM	★	★
Diff 2	22325	7c7180a	- remove unnecessary ifdef block	Nov 14 2017, 11:14 AM	★	★
Diff 3	22384	4db1ad1	R32:da49f7bf76aaa1e229f8b5455531cf697d9e5943	Nov 15 2017, 10:27 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
17bbac552f66	ccefd83766f5	03e712bf49e1	Geetam Chawla	remove unnecessary ifdef block	Nov 14 2017, 11:12 AM
03e712bf49e1	fb0a025f76e2	7c7180a8ab66	Geetam Chawla	fix "none" being set as default compiler on windows (Show More…)	Nov 13 2017, 10:56 PM