Fix colours not updating in systemsettings
ClosedPublic

Authored by davidedmundson on Oct 21 2017, 2:05 PM.

Details

Summary

(after a lot of looking, it turns it's out not a bug in the QQC desktop
style)

KSharedConfig::openConfig() opens the config based on the app name.

The app name comes from the exec name, or
KAboutData::setApplicationData.
setApplicationData only works on an existing qApp.

This means the QPT loaded in the QApp uses the wrong config.
The effect is minimal because most stuff is in kdeglobals, but it means
the KSharedConfigPtr is not shared with the one used elsewhere in the
app. This is wasteful, but also means the QPT calling
reparseConfiguration doesn't take effect, leading to colours not being
dynamically updated

Diff Detail

Repository
R124 System Settings
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
davidedmundson created this revision.Oct 21 2017, 2:05 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 21 2017, 2:05 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

fix typo in summary

davidedmundson edited the summary of this revision. (Show Details)Oct 21 2017, 2:16 PM
ngraham added inline comments.
app/main.cpp
34

"setApplicicationName"? :-)

yes, I meant that. It's what I had in my working dir..apparently I can't git properly.

mart accepted this revision.Oct 23 2017, 9:27 AM
This revision is now accepted and ready to land.Oct 23 2017, 9:27 AM
This revision was automatically updated to reflect the committed changes.