Differential D7436

kimpanel: change highlight color
ClosedPublic
Actions

Authored by xuetianweng on Aug 20 2017, 5:33 PM.

Details

Reviewers
guoyunhe
Group Reviewers
Plasma
Commits
R119:5377b6b03b8d: kimpanel: change highlight color
Summary

Before:

Highlighted candidate uses theme.highlightColor for text, but this color should only be used in background color, not text color. This style is different from other KDE UI.

After:

Highlighted candidate uses Plasma's svg as highlight. PlasmaComponents.Highlight is not used here because it is View-specific item and we do not want use the View but keep using Layout here because view does not work well with the pattern like "always making view size to fit the content".

It is more similar to general KDE design.

Diff Detail

Repository
R119 Plasma Desktop
Branch
arcpatch-D7436
Lint
No Linters Available
Unit
No Unit Test Coverage
guoyunhe created this revision.Aug 20 2017, 5:33 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 20 2017, 5:33 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
guoyunhe added a reviewer: Plasma.Aug 20 2017, 5:33 PM
guoyunhe edited the summary of this revision. (Show Details)
xuetianweng added a subscriber: xuetianweng.Aug 20 2017, 10:44 PM

Can you try to make use of PlasmaComponents.Highlight instead of custom highlight like this?

guoyunhe added a comment.Aug 21 2017, 8:42 PM
In D7436#138011, @xuetianweng wrote:

Can you try to make use of PlasmaComponents.Highlight instead of custom highlight like this?

Tried and failed... So I have to leave it like this...

xuetianweng commandeered this revision.Aug 23 2017, 7:27 PM
xuetianweng added a reviewer: guoyunhe.
xuetianweng updated this revision to Diff 18624.Aug 23 2017, 7:30 PM

Use plasma svg as highlight

xuetianweng edited the summary of this revision. (Show Details)Aug 23 2017, 7:36 PM
guoyunhe accepted this revision.Aug 23 2017, 8:02 PM

It looks good. Only one small problem: when hovering mouse on selected candidate, its height will change.

This revision is now accepted and ready to land.Aug 23 2017, 8:02 PM
xuetianweng added a comment.Aug 23 2017, 8:24 PM

That's a bug in breeze. Should be fixed with https://phabricator.kde.org/D7491

Closed by commit R119:5377b6b03b8d: kimpanel: change highlight color (authored by xuetianweng). · Explain WhyAug 23 2017, 8:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 18624

View Options

applets/kimpanel/package/contents/ui/CandidateHighlight.qml

Loading...
View Options

applets/kimpanel/package/contents/ui/InputPanel.qml

Loading...