Port some displayWidth/displayHeight usages to Screens::size()
ClosedPublic

Authored by graesslin on Jun 8 2016, 10:48 AM.

Details

Summary

KWin::displayWidth and KWin::displayHeight are bound to X11 which
doesn't make much sense on X11. In addition KWin internally knows
the overall display dimensions through the Screens singleton class.

Diff Detail

Repository
R108 KWin
Branch
display-size-to-screens
Lint
No Linters Available
Unit
No Unit Test Coverage
graesslin updated this revision to Diff 4290.Jun 8 2016, 10:48 AM
graesslin retitled this revision from to Port some displayWidth/displayHeight usages to Screens::size().
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added a reviewer: KWin.
Restricted Application added a project: KWin. · View Herald TranscriptJun 8 2016, 10:48 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
graesslin planned changes to this revision.Jun 8 2016, 12:48 PM

The code needs to consider xrandr output panning.

graesslin updated this revision to Diff 18547.Aug 22 2017, 4:55 PM
  • rebased to current master
  • added a virtual Screens::displaySize which returns same as ::size by default but on X11 the good old displayWidth/displayHeight
  • code in geometry.cpp which is X11 bound used this new displaySize, so also panning is supported
graesslin updated this revision to Diff 18548.Aug 22 2017, 5:27 PM

Replaced all remaining displayWidth/displayHeight usages.

graesslin added a subscriber: plasma-devel.
This revision was automatically updated to reflect the committed changes.