Workaround bug in QT_QUICK_CONTROLS_1_STYLE usage in Qt
ClosedPublic

Authored by fvogt on Aug 18 2017, 9:23 AM.

Details

Summary

Setting the style manually is necessary as there is only a variable that
applies to both quick controls versions, so it needs to be overwritten to not
cause a warning on every application start. The current way of setting it directly
got defeated by ugly bugs in QQuickControlSettings1, which need to be worked around.
See the added comments for an explanation.

Test Plan

Set the variables manually, now works consistently everywhere without showing warnings.
For some reason I feel much dirtier now.

Diff Detail

Repository
R120 Plasma Workspace
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
fvogt created this revision.Aug 18 2017, 9:23 AM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 18 2017, 9:23 AM
mart accepted this revision.Aug 18 2017, 9:31 AM
This revision is now accepted and ready to land.Aug 18 2017, 9:31 AM
fvogt closed this revision.Aug 18 2017, 9:34 AM

Even arc land doesn't close diffs reliably now apparently...