Differential D7349

Adds a slider to control the brightness of the image
ClosedPublic
Actions

Authored by atulsharma on Aug 16 2017, 4:35 PM.

Details

Reviewers
mart
Group Reviewers
Koko
Maniphest Tasks
T6268: Implementing the main ImageViewer
Commits
R659:4c563acdbe1a: Adds a slider to control the brightness of the image
Summary

Refs T6268

  • Adds slider in the imageviewer to change the brightness

Diff Detail

Repository
R659 Koko Image Gallery
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
atulsharma created this revision.Aug 16 2017, 4:35 PM
atulsharma updated this revision to Diff 18245.Aug 16 2017, 4:37 PM

visible when controlsVisible

atulsharma updated this revision to Diff 18246.Aug 16 2017, 4:42 PM

Adds a tooltip onHover

mart edited edge metadata.Aug 17 2017, 9:30 AM

you are not doing anything to the image but just applying an effect to the visualization.
this should be actual image editing, saving a modified jpeg on disk

mart requested changes to this revision.Aug 17 2017, 9:30 AM
This revision now requires changes to proceed.Aug 17 2017, 9:30 AM
atulsharma updated this revision to Diff 18415.Aug 19 2017, 10:48 PM
atulsharma edited edge metadata.

handles the brightness change in C++ class

mart accepted this revision.Aug 21 2017, 8:49 AM
This revision is now accepted and ready to land.Aug 21 2017, 8:49 AM
Closed by commit R659:4c563acdbe1a: Adds a slider to control the brightness of the image (authored by atulsharma). · Explain WhyAug 21 2017, 11:03 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MqmlUiKirigami/ImageViewer.qml (29 lines)

Diff 18246

View Options

qmlUiKirigami/ImageViewer.qml

Loading...