Add Pony highlighting
ClosedPublic

Authored by jpoelen on Aug 13 2017, 10:18 PM.

Details

Diff Detail

Repository
R216 Syntax Highlighting
Branch
pony
Lint
No Linters Available
Unit
No Unit Test Coverage
jpoelen created this revision.Aug 13 2017, 10:18 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 13 2017, 10:18 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript

Looks already quite good. But I think one more iteration to especially fix the licensing would be nice.

autotests/foldingtest.pony
2 ↗(On Diff #18110)

Is this file intentionally added?

autotests/input/highlight.pony
2

Can you add a license as comment? MIT license is preferred.

data/syntax/pony.xml
12

Can you add license="MIT" as license?

284

You may want to add # to the weakDeliminator list, to make cursor navigation like ctrl+left work correctly, since some keywords contain #.

jpoelen updated this revision to Diff 18194.Aug 15 2017, 3:23 PM
This comment was removed by jpoelen.
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 15 2017, 3:23 PM
jpoelen updated this revision to Diff 18196.Aug 15 2017, 3:27 PM

Pony: Support for attributes and best behavior for function definitions. Add license and removed autotests/foldingtest.pony

Closed by commit R216:683893d1c17c: Add Pony highlighting (authored by Unknown Object (User), committed by dhaumann). · Explain WhyAug 17 2017, 8:43 PM
This revision was automatically updated to reflect the committed changes.