Adds view-close( working), share( working), edit action to imageviewer
ClosedPublic

Authored by atulsharma on Jul 28 2017, 6:52 PM.

Details

Summary

Refs T6268

  • Share action is implemented using Purpose.AlternativesView

Diff Detail

Repository
R659 Koko Image Gallery
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
atulsharma created this revision.Jul 28 2017, 6:52 PM
atulsharma updated this revision to Diff 17845.Aug 7 2017, 4:44 PM

Basic implementation for share action using Purpose framework

atulsharma updated this revision to Diff 17846.Aug 7 2017, 4:51 PM

Little update

atulsharma retitled this revision from Adds view-close( working), edit, share action to imageviewer to Adds view-close( working), share( working), edit action to imageviewer.Aug 7 2017, 4:56 PM
atulsharma edited the summary of this revision. (Show Details)
mart added inline comments.Aug 7 2017, 5:08 PM
qmlUiKirigami/ImageViewer.qml
54

probably in square brackets?

qmlUiKirigami/ShareDialog.qml
23

shouldn't import plasma stuff in an application

27

This shouldn't be PlasmaCore.Dialog

try using a Kirigami.OverlaySheet instead

30

property alias inputData: view.inputData

atulsharma updated this revision to Diff 17850.Aug 7 2017, 6:53 PM
atulsharma marked 3 inline comments as done.

functioning now

atulsharma marked an inline comment as done.Aug 7 2017, 6:53 PM
mart added inline comments.Aug 7 2017, 6:56 PM
qmlUiKirigami/ShareDialog.qml
42

this should be the header of the alternativesview

45

this should be directly the child of the overlaydrawer, so it will use it as flickable

atulsharma updated this revision to Diff 17866.Aug 8 2017, 8:35 AM

Notification whether the image is shared successfully or not

mart accepted this revision.Aug 8 2017, 10:07 AM
This revision is now accepted and ready to land.Aug 8 2017, 10:07 AM
This revision was automatically updated to reflect the committed changes.