Opens the imageViewer depending upon the imagePath provided
ClosedPublic

Authored by atulsharma on Jul 13 2017, 1:03 PM.

Diff Detail

Repository
R659 Koko Image Gallery
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
atulsharma created this revision.Jul 13 2017, 1:03 PM
atulsharma updated this revision to Diff 16707.Jul 14 2017, 2:12 PM

Emit showImageViewer signal after the model is populated

atulsharma edited the summary of this revision. (Show Details)Jul 14 2017, 2:34 PM
atulsharma edited the summary of this revision. (Show Details)
mart requested changes to this revision.Jul 14 2017, 2:46 PM
mart added inline comments.
src/imagefoldermodel.cpp
114

couldn't the qml part just call indexForUrl? i don't like this back and forth of signals, makes it hard to follow

This revision now requires changes to proceed.Jul 14 2017, 2:46 PM
atulsharma updated this revision to Diff 16708.Jul 14 2017, 2:59 PM
atulsharma edited edge metadata.
atulsharma edited the summary of this revision. (Show Details)

removed back and forth signals

atulsharma updated this revision to Diff 16709.Jul 14 2017, 3:01 PM

just a little commenting

mart accepted this revision.Jul 14 2017, 3:03 PM
This revision is now accepted and ready to land.Jul 14 2017, 3:03 PM
This revision was automatically updated to reflect the committed changes.